🔧 chore(data-secrecy v2): prep DataSecrecyWaiver model to be deleted
#95393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Alter field organization on datasecrecywaiver
--
SET CONSTRAINTS "sentry_datasecrecywa_organization_id_e6f91a82_fk_sentry_or" IMMEDIATE; ALTER TABLE "sentry_datasecrecywaiver" DROP CONSTRAINT "sentry_datasecrecywa_organization_id_e6f91a82_fk_sentry_or"; |
iamrajjoshi
force-pushed
the
raj/ds-v2/deprecate-v1/delete-model-1
branch
from
c2afc07 to
c981518
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Alter field organization on datasecrecywaiver
--
SET CONSTRAINTS "sentry_datasecrecywa_organization_id_e6f91a82_fk_sentry_or" IMMEDIATE; ALTER TABLE "sentry_datasecrecywaiver" DROP CONSTRAINT "sentry_datasecrecywa_organization_id_e6f91a82_fk_sentry_or"; |
vgrozdanic
approved these changes
Jul 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95393 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 10508 10508
Lines 606278 606278
Branches 23716 23716
=======================================
+ Hits 466718 466722 +4
+ Misses 137182 137178 -4
Partials 2378 2378 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we start building Data Secrecy V2, lets first remove the old models and logic. Currently there are no waivers being created so its safe to remove this logic.
contributes to ECO-824
Sets the org FK to not be a db constraint.